Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
pagedjs
pagedjs
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 154
    • Issues 154
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Tools
  • pagedjspagedjs
  • Issues
  • #183

Closed
Open
Opened Mar 10, 2020 by Stouffi@Stouffi
  • Report abuse
  • New issue
Report abuse New issue

createBreakToken contains a return statement which should be removed.

First thanks for the great job done on this project.

About the issue: everything is in the title. This line https://gitlab.pagedmedia.org/tools/pagedjs/blob/master/src/chunker/layout.js#L288 once removed, fixes a bug that occurs when the content at the end of a page is overflowing only by its margin box. The rest of the document, after the margin box, is then not visible as the return statement acts like a noop instead of using the closest element with data-ref as mentioned in the comment just two lines above.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: tools/pagedjs#183