Make sure that we still comply with an 'explicit' page break

7500da5a · Guillaume · 895b51ec · 7500da5a · 7500da5a · 7500da5a
Commit 7500da5a authored Sep 11, 2020 by Guillaume
9 changed files
--- a/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-nested-section-spec-js-long-nested-section-should-create-a-pdf-1-snap.png
+++ b/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-nested-section-spec-js-long-nested-section-should-create-a-pdf-1-snap.png
--- a/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-nested-section-spec-js-long-nested-section-should-create-a-pdf-2-snap.png
+++ b/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-nested-section-spec-js-long-nested-section-should-create-a-pdf-2-snap.png
--- a/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-1-snap.png
+++ b/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-1-snap.png
--- a/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-2-snap.png
+++ b/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-2-snap.png
--- a/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-3-snap.png
+++ b/specs/breaks/break-inside/break-inside-avoid/__image_snapshots_linux__/long-section-break-before-spec-js-long-section-break-before-should-create-a-pdf-3-snap.png
--- a/specs/breaks/break-inside/break-inside-avoid/long-nested-section.html
+++ b/specs/breaks/break-inside/break-inside-avoid/long-nested-section.html
@@ -4,7 +4,7 @@
 	<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
 	<meta http-equiv="Content-Style-Type" content="text/css"/>
 	<title>
-		Long section
+		Long nested section
 	</title>
 	<script src="../../../../dist/paged.polyfill.js"></script>
 	<style>

--- a/specs/breaks/break-inside/break-inside-avoid/long-nested-section.spec.js
+++ b/specs/breaks/break-inside/break-inside-avoid/long-nested-section.spec.js
 const TIMEOUT = 10000;

-describe("long section", () => {
+describe("long nested section", () => {
 	let page;
 	beforeAll(async () => {
 		page = await loadPage("breaks/break-inside/break-inside-avoid/long-nested-section.html");

--- a/specs/breaks/break-inside/break-inside-avoid/long-section-break-before.html
+++ b/specs/breaks/break-inside/break-inside-avoid/long-section-break-before.html
+<!DOCTYPE html PUBLIC>
+<html lang="en" lang="en">
+<head>
+	<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
+	<meta http-equiv="Content-Style-Type" content="text/css"/>
+	<title>
+		Long section break before
+	</title>
+	<script src="../../../../dist/paged.polyfill.js"></script>
+	<style>
+		@page {
+			size: 140mm 150mm;
+			margin: 0px;
+			padding: 0px;
+		}
+
+		section {
+			break-before: page;
+			break-inside: avoid;
+		}
+
+		@media screen {
+
+			body {
+				background-color: whitesmoke;
+			}
+
+			.pagedjs_page {
+				background-color: white;
+				box-shadow: 0 0 0 1px #bfbfbf;
+				margin-top: 10mm;
+				margin-left: 10mm;
+			}
+		}
+	</style>
+</head>
+<body>
+<section>
+	<h3>Section title</h3>
+
+	<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed fermentum vel tortor at suscipit. Donec augue leo, viverra sit amet mauris eget, blandit vestibulum lacus. Quisque
+		a nibh ut ligula elementum efficitur et molestie mauris. Suspendisse potenti. Nam dapibus orci nec vestibulum volutpat. Nunc magna nibh, tristique eget ornare vel, convallis
+		eget quam. Donec risus neque, mattis ac finibus at, ullamcorper vitae tellus. Aenean faucibus turpis quis ligula tincidunt consectetur. Ut sed tortor urna. Vivamus volutpat
+		turpis vitae tortor tempor, in luctus arcu fringilla. Quisque hendrerit ligula vitae nunc porta elementum.</p>
+
+	<p>Etiam euismod interdum tellus, vitae semper nisi semper in. Curabitur tempus enim vel lectus laoreet ornare. Quisque venenatis ante in maximus scelerisque. Quisque auctor
+		volutpat nibh, ac finibus dui. Integer et nisi sed odio rhoncus rhoncus. Nunc auctor mi a erat pretium, sit amet placerat felis congue. Integer id mattis mauris. Etiam suscipit
+		pulvinar enim, sed finibus tortor. Nulla purus nisi, malesuada at orci in, fringilla aliquet mi.</p>
+</section>
+<section>
+	<p>1</p>
+	<p>2</p>
+	<p>3</p>
+	<p>4</p>
+	<p>5</p>
+	<p>6</p>
+	<p>7</p>
+	<p>8</p>
+	<p>9</p>
+	<p>10</p>
+	<p>11</p>
+	<p>12</p>
+	<p>13</p>
+	<p>14</p>
+	<p>15</p>
+	<p>16</p>
+	<p>17</p>
+	<p>18</p>
+</section>
+</body>
+</html>
--- a/specs/breaks/break-inside/break-inside-avoid/long-section-break-before.spec.js
+++ b/specs/breaks/break-inside/break-inside-avoid/long-section-break-before.spec.js
+const TIMEOUT = 10000;
+
+describe("long section break before", () => {
+	let page;
+	beforeAll(async () => {
+		page = await loadPage("breaks/break-inside/break-inside-avoid/long-section-break-before.html");
+		return page.rendered;
+	}, TIMEOUT);
+
+	afterAll(async () => {
+		if (!DEBUG) {
+			await page.close();
+		}
+	});
+
+	it("should ignore comply with break-before:page (precedence over break-inside:avoid)", async () => {
+		let pages = await page.$$eval(".pagedjs_page", (r) => r.length);
+		expect(pages).toBe(3);
+	});
+
+	if (!DEBUG) {
+		it("should create a pdf", async () => {
+			let pdf = await page.pdf(PDF_SETTINGS);
+			expect(pdf).toMatchPDFSnapshot(1);
+			expect(pdf).toMatchPDFSnapshot(2);
+			expect(pdf).toMatchPDFSnapshot(3);
+		});
+	}
+});